Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

Conversation

@johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 4, 2022

No description provided.

@johnstcn johnstcn requested a review from khorne3 March 4, 2022 21:25
@johnstcn johnstcn self-assigned this Mar 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

✨ Coder.com for PR #877 deployed! It will be updated on every commit.

setup/docker.md Outdated
Simply create a new directory (for example, named `c4d`) and place the following
content in a file named `docker-compose.yml`:

```yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the extra spaces here?

Suggested change
```yaml
```yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried keeping the current indentation level; is there anything magical about that here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, maybe my eyes deceive me - I thought this line was off compared to the rest. Disregard!

setup/docker.md Outdated
- 7080:7080/tcp
volumes:
- /var/run/docker.sock:/var/run/docker.sock
- ${HOME}/.coder:/var/run/coder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you nee the { }?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a habit of mine, it's probably not necessary.

setup/docker.md Outdated

```shell-session
docker-compose up -d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be recommending docker compose up -d?

Copy link
Member Author

@johnstcn johnstcn Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally chose the docker-compose syntax in case folks on older versions want to try this. The new version is backwards-compatible:

$ ls -l $(which docker-compose)
lrwxr-xr-x 1 root wheel 68 Feb 27 21:05 /usr/local/bin/docker-compose -> /Applications/Docker-4.5.0.app/Contents/Resources/bin/docker-compose


For organizations, we recommend one Docker host per team of 5-10 developers.

## Docker Compose
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was something I had suggested before (#818 (comment)), I suppose if we're good with the additional maintenance then more options is always good

cc @Emyrk

@johnstcn johnstcn merged commit db2dd26 into main Mar 7, 2022
@johnstcn johnstcn deleted the cj/docs/c4d-compose branch March 7, 2022 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants