-
Notifications
You must be signed in to change notification settings - Fork 80
add sample compose file #877
Conversation
|
✨ Coder.com for PR #877 deployed! It will be updated on every commit.
|
setup/docker.md
Outdated
| Simply create a new directory (for example, named `c4d`) and place the following | ||
| content in a file named `docker-compose.yml`: | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the extra spaces here?
| ```yaml | |
| ```yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried keeping the current indentation level; is there anything magical about that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, maybe my eyes deceive me - I thought this line was off compared to the rest. Disregard!
setup/docker.md
Outdated
| - 7080:7080/tcp | ||
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| - ${HOME}/.coder:/var/run/coder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you nee the { }?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a habit of mine, it's probably not necessary.
setup/docker.md
Outdated
|
|
||
| ```shell-session | ||
| docker-compose up -d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be recommending docker compose up -d?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally chose the docker-compose syntax in case folks on older versions want to try this. The new version is backwards-compatible:
$ ls -l $(which docker-compose)
lrwxr-xr-x 1 root wheel 68 Feb 27 21:05 /usr/local/bin/docker-compose -> /Applications/Docker-4.5.0.app/Contents/Resources/bin/docker-compose
|
|
||
| For organizations, we recommend one Docker host per team of 5-10 developers. | ||
|
|
||
| ## Docker Compose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was something I had suggested before (#818 (comment)), I suppose if we're good with the additional maintenance then more options is always good
cc @Emyrk
No description provided.