Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

Conversation

@deansheather
Copy link
Member

No description provided.

johnstcn and others added 3 commits February 10, 2022 09:30
* chore: document hostPaths mounted by CVMs

* fix table

* add link to sysbox design nodes

* chore: edit text

* remove stray character

Co-authored-by: Katie Horne <katie@coder.com>
@deansheather deansheather requested a review from khorne3 February 11, 2022 21:12
@deansheather
Copy link
Member Author

Very rough. I'm not super happy with the Cloudflare section taking up the whole document but I'm unsure how to solve it

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2022

✨ Coder.com for PR #842 deployed! It will be updated on every commit.

@@ -0,0 +1,120 @@
---
title: GeoDNS
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we call this "global load balancing," or something similar?

If you google GeoDNS, this is the top hit: https://en.wikipedia.org/wiki/GeoDNS

Do these docs only refer to Anycast routing, or can people use this if they are using split-horizon DNS?

- A primary access URL (e.g. `https://primary.example.com`).
- One or more satellite access URLs (e.g. `https://sydney.example.com`,
`https://london.example.com`).
- A GeoDNS load balancer access URL (e.g. `https://coder.example.com`). The
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCP does something similar with Anycast, https://cloud.google.com/load-balancing

We should distinguish whether this feature is for people using Anycast (a CDN or global load balancing) versus split-horizon DNS (where the DNS responses vary according to the user's IP address/location)

Katie Horne and others added 4 commits February 14, 2022 09:14
@khorne3
Copy link
Contributor

khorne3 commented Feb 14, 2022

@deansheather I don't think the Cloudflare section is too big of a problem, but if you'd like, we can split it into its own guide? Then people could use if if they need the help in that section, otherwise they can ignore if they have a load balancer already

@deansheather
Copy link
Member Author

If you're OK with it then I think it's fine

[SC-20846]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #20846: Allowed hosts docs.

@khorne3
Copy link
Contributor

khorne3 commented Feb 14, 2022

@deansheather do you have any thoughts on @jawnsy 's suggestions?

  • Calling this feature global load balancing or similar
  • Distinguish whether this feature is for people using Anycast (a CDN or global load balancing) versus split-horizon DNS (where the DNS responses vary according to the user's IP address/location)

Other than that, I think all else is ok

@khorne3 khorne3 changed the base branch from main to release-1.28 February 14, 2022 18:07
@deansheather
Copy link
Member Author

@jawnsy GeoDNS is a correct term for it AFAIK and means the same thing as split-horizon DNS. What are your thoughts on disambiguating it in the first paragraph but keeping it called GeoDNS?

@deansheather
Copy link
Member Author

@khorne3

  • I can rename it to "global load balancing" if you think it's a good idea, GeoDNS is a good name though IMO
  • I added a paragraph that says it will work with both anycast and split-horizon

@deansheather
Copy link
Member Author

I've renamed it to "Proximity based configuration" but I don't think that's a good name yet. Also, I've replaced most of the references to "GeoDNS access URL" with "unified access URL" instead

@deansheather deansheather requested a review from jawnsy February 15, 2022 23:27
@khorne3 khorne3 merged commit eb0f5c0 into release-1.28 Feb 16, 2022
@khorne3 khorne3 deleted the geo-dns branch February 16, 2022 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants