Skip to content

Add Okta OIDC Guide #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 8, 2021
Merged

Add Okta OIDC Guide #393

merged 9 commits into from
Jun 8, 2021

Conversation

IAmHughes
Copy link
Contributor

This PR adds the Okta OIDC guide for creating an app to use OIDC with Okta and Coder.

@IAmHughes IAmHughes added the docs 📝 Improvements or additions to documentation label Jun 8, 2021
@IAmHughes IAmHughes self-assigned this Jun 8, 2021
@github-actions github-actions bot requested a deployment to codercom-preview-docs June 8, 2021 13:07 Pending
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2021

✨ Coder.com for PR #393 deployed! It will be updated on every commit.

@github-actions github-actions bot requested a deployment to codercom-preview-docs June 8, 2021 16:37 Pending
@github-actions github-actions bot requested a deployment to codercom-preview-docs June 8, 2021 16:41 Pending
@github-actions github-actions bot requested a deployment to codercom-preview-docs June 8, 2021 16:43 Pending
@github-actions github-actions bot requested a deployment to codercom-preview-docs June 8, 2021 16:47 Pending
@IAmHughes IAmHughes marked this pull request as ready for review June 8, 2021 16:54
@IAmHughes
Copy link
Contributor Author

This is ready for review. For some reason, the deploy preview seems broken for the Docs tab and I'm not sure why? @bpmct or @ericpaulsen do you know?

@ericpaulsen
Copy link
Member

LGTM - only thing I'd recommend adding is context around Okta groups & users being already able to access Coder. No need to manually add users on the Coder side.

@IAmHughes
Copy link
Contributor Author

Okta groups & users being already able to access Coder. No need to manually add users on the Coder side.

I'm not sure what you mean @ericpaulsen? Within Okta, if no one is assigned the application (step 3 in the guide), no one can access Coder.

@ericpaulsen
Copy link
Member

Yes - my comment assumed that such groups & users would be assigned to the application. Apologies for the lack of clarity.

@IAmHughes
Copy link
Contributor Author

Any ideas on the Docs tab not working in the preview deployment @ericpaulsen ?

@ericpaulsen
Copy link
Member

Not sure. I'm not familiar with debugging the Vercel preview. In my experience, issues with the preview aren't typically indicative of an issue with the commit once merged.

@IAmHughes IAmHughes merged commit 876cf1a into main Jun 8, 2021
@IAmHughes IAmHughes deleted the IAmHughes/add-okta-oidc-guide branch June 8, 2021 17:55
@greyscaled
Copy link
Contributor

@all-contributors please add @IAmHughes for bug, content, idea

@allcontributors
Copy link
Contributor

@vapurrmaid

I've put up a pull request to add @IAmHughes! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📝 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants