Fix: Remove pull_request event from preview deploys
#109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmct
approved these changes
Feb 22, 2021
|
@IAmHughes it looks like the action is firing now, but the checkout syntax doesn't work for PRs as it does for pushes. similarly, it looks like it is firing the action twice now. Is it safe to remove the "push" event entirely and only start builds once a PR is open? |
IAmHughes
changed the title
IAmHughes
changed the title
pull_request event from preview deploys
|
@bpmct as we discussed, when you give a 👍 I'll merge. |
bpmct
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull_requestwas added as an event type to trigger deploys to preview from forks to assist with the OSS contribution process. Unfortunately, we depend on a secret to access a private repository which is NOT passed to the fork for security purposes (GitHub security enforces this). Therefore, I'm removing thepull_requestevent entirely which should fix the issues we were seeing.Note: Pushes to branches in PRs will still trigger builds