fix: broken implementation and tests#8
Merged
DanielleMaywood merged 5 commits intomainfrom Apr 16, 2025
Merged
Conversation
Unfortunately it appears I didn't manually test well enough. I've now fixed how the arguments are forwarded to the `code-server` CLI. I've also fixed any tests that broke due to the change.
DanielleMaywood
force-pushed
the
dm-fix-broken-stuff
branch
from
cce10e5 to
2eb7807
Compare
DanielleMaywood
commented
Apr 15, 2025
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (9)
- src/code-server/install.sh: Language not supported
- test/code-server/code-server-auth-none.sh: Language not supported
- test/code-server/code-server-auth-password.sh: Language not supported
- test/code-server/code-server-cert.sh: Language not supported
- test/code-server/code-server-cert/Dockerfile: Language not supported
- test/code-server/code-server-socket-with-mode.sh: Language not supported
- test/code-server/code-server-socket.sh: Language not supported
- test/code-server/code-server-workspace.sh: Language not supported
- test/code-server/scenarios.json: Language not supported
mafredri
reviewed
Apr 15, 2025
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
Left a few suggestions, lmk what you think.
mafredri
approved these changes
Apr 16, 2025
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
Nice work! Had a minor suggestion still but otherwise good to go 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately it appears I didn't manually test well enough. I've now fixed how the arguments are forwarded to the
code-serverCLI. I've also fixed any tests that broke due to the change.