Skip to content

feat: add i18n in login page #5947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 13, 2023
Merged

feat: add i18n in login page #5947

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ade3da3
feat: add i18n in login page
zhaozhiming Jan 4, 2023
b53a57a
fix: add word space and put the app name into the title
zhaozhiming Jan 6, 2023
9aa26f4
fix: remove duplicate replace title
zhaozhiming Jan 6, 2023
d66eed1
fix: prettier format code
zhaozhiming Jan 6, 2023
e94f368
fix: fix typescript check warning
zhaozhiming Jan 6, 2023
eed3122
fix: add zh-cn locale file code owner
zhaozhiming Jan 6, 2023
8eabb16
fix: use existing flag locale to the login page
zhaozhiming Jan 7, 2023
9f50607
Merge branch 'main' into feat-i18n-login
jsjoeio Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: add zh-cn locale file code owner
  • Loading branch information
@zhaozhiming
zhaozhiming committed Jan 6, 2023
commit eed3122ebc19f5797c4fcdbee5102bfca8de8191
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
ci/helm-chart/ @Matthew-Beckett @alexgorbatchev

docs/install.md @GNUxeava

src/node/i18n/locales/zh-cn.json @zhaozhiming
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: may have to give write access...

Related: https://github.com/orgs/community/discussions/23042

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about .github/CODEOWNERS. Is there anything else I need to do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you're good here!