feat: add displayLang test #5495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5495 +/- ##
=======================================
Coverage 72.44% 72.44%
=======================================
Files 30 30
Lines 1673 1673
Branches 366 366
=======================================
Hits 1212 1212
Misses 398 398
Partials 63 63 Continue to review full report at Codecov.
|
jsjoeio
force-pushed
the
jsjoeio/lang-patch
branch
from
c805159 to
3db2390
Compare
This adds a slimmed-down version of the Spanish Language Pack and also adds a `languagepacks.json` to the e2e `workspaceDir` which allows use to run a test suite passing the `--locale es` flags to simulate a different display language.
This tests loading code-server in Spanish using the `--locale` flag.
jsjoeio
force-pushed
the
jsjoeio/lang-patch
branch
from
3db2390 to
4452b71
Compare
jsjoeio
commented
Aug 29, 2022
test/e2e/extensions/ms-ceintl.vscode-language-pack-es-1.70.0/package.json
Show resolved
Hide resolved
test/e2e/extensions/ms-ceintl.vscode-language-pack-es-1.70.0/translations/main.i18n.json
Show resolved
Hide resolved
code-asher
approved these changes
Aug 30, 2022
test/e2e/extensions/ms-ceintl.vscode-language-pack-es-1.70.0/package.json
Show resolved
Hide resolved
Good call. I'll double-check that and/or explore starting from scratch. I'm going to move this back to draft and address changes. |
code-asher
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an e2e test to ensure our language patch is working as expected.
7b3af0074186a31b540173c75758b033.webm
NOTE to self: won't pass with dev builds because lang. patch only works with prod builds. Might need to conditionally run this test.
Notes
When you install a language pack, two things happen:
--extensions-dir(expected, same as other extensions)languagepacks.jsonto~/.local/share/code-server(see example gist)That means in order for this test to pass consistently (without relying on a network connection), we need to add both of those things in global setup or in the test setup.
To test locally and just this test, I run this command:
Fixes #5367