refactor: open function #5257
Merged
refactor: open function #5257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no clear reason as to why we needed to use type assertions when initializing both `args` and `options` in `open` so I refactored them both.
|
✨ code-server docs for PR #5257 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5257 +/- ##
==========================================
+ Coverage 72.12% 72.47% +0.34%
==========================================
Files 30 30
Lines 1668 1671 +3
Branches 367 367
==========================================
+ Hits 1203 1211 +8
+ Misses 399 397 -2
+ Partials 66 63 -3
Continue to review full report at Codecov.
|
code-asher
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
opento remove some unnecessary things and make it easier to test.Related #5153