refactor(heart): bind class methods and make beat async #5142
+28
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ code-server docs for PR #5142 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5142 +/- ##
==========================================
+ Coverage 71.62% 71.73% +0.10%
==========================================
Files 30 30
Lines 1688 1691 +3
Branches 375 375
==========================================
+ Hits 1209 1213 +4
+ Misses 410 409 -1
Partials 69 69
Continue to review full report at Codecov.
|
jsjoeio
force-pushed
the
jsjoeio/fix-heart-undefined
branch
2 times, most recently
from
6627b0b to
dd2829a
Compare
This allows us to properly await heart.beat() in our tests and remove the HACK I added before.
This allows the functions to maintain access to the Heart instance (or `this`) even when they are passed to other functions. We do this because we pass both `isActive` and `beat` to `heartbeatTimer`.
jsjoeio
force-pushed
the
jsjoeio/fix-heart-undefined
branch
from
dd2829a to
4d29cd5
Compare
code-asher
reviewed
May 3, 2022
code-asher
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #5122, I didn't
bindthe class methods, which meant passing them to another function them callingthisin them would result inundefined.I also cleaned up the hack I used before with some async logic.
References
Partially related to #5131