Make installer work on any os/arch and add installer tests #3712
Conversation
code-asher
force-pushed
the
installer
branch
3 times, most recently
from
5e49d2d to
c23439f
Compare
Codecov Report
@@ Coverage Diff @@
## main #3712 +/- ##
=======================================
Coverage 62.89% 62.89%
=======================================
Files 35 35
Lines 1838 1838
Branches 371 371
=======================================
Hits 1156 1156
Misses 577 577
Partials 105 105 Continue to review full report at Codecov.
|
code-asher
force-pushed
the
installer
branch
3 times, most recently
from
3bb0c6d to
8133e7e
Compare
|
Will this fix #3585? |
code-asher
force-pushed
the
installer
branch
2 times, most recently
from
d472d4e to
20bc84b
Compare
|
Nope but I'll add a fix. |
code-asher
force-pushed
the
installer
branch
4 times, most recently
from
b8dce0f to
ed3e60d
Compare
| test: | ||
| name: Run script unit tests | ||
| runs-on: ubuntu-latest | ||
| # This runs on Alpine to make sure we're testing with actual sh. |
There was a problem hiding this comment.
I'm confused, doesn't the script force things to run as bash due to the shebang? Also, Ubuntu should include Bourne shell (e.g. dash) too
There was a problem hiding this comment.
The installer shebang is #!/bin/sh but since that's often a symlink to bash/dash/etc I've used Alpine to make sure it's really using sh to catch any bashisms that might sneak in there.
There was a problem hiding this comment.
Ah! Good point, I was looking at test-scripts.sh, which uses bash explicitly: #!/usr/bin/env bash
This makes sense then. I think Ubuntu should be using dash for /bin/sh by default, though I'm not sure if GitHub Actions does some customization to the environment:
$ docker run --rm -it ubuntu:latest
root@081f1b5d886d:/# which sh
/usr/bin/sh
root@081f1b5d886d:/# ls -al /usr/bin/sh
lrwxrwxrwx 1 root root 4 Jul 18 2019 /usr/bin/sh -> dash
There's also a handy checkbashisms script in devscripts (install it with apt) that you may find useful. I use it in my dotfiles build: https://github.com/jawnsy/dotfiles/blob/0a27557f15aba599056171abc5ff936e7b530d13/.github/workflows/build.yml#L49
There was a problem hiding this comment.
Oh that's dope! I'll definitely add that.
Previously if the prefix was non-existent we would switch to root even if the user does have the permissions to create the directory. Fixes coder#3585
No description provided.