dev(testing): separate unit and e2e tests #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
changed the title
jsjoeio
commented
Mar 10, 2021
.eslintrc.yaml
Outdated
Comment on lines
35
to
41
| [ | ||
| error, | ||
| { | ||
| alphabetize: { order: "asc" }, | ||
| groups: [["builtin", "external", "internal"], "parent", "sibling"], | ||
| }, | ||
| ] |
jsjoeio
force-pushed
the
jsjoeio-2646-separate-testing
branch
from
e09359a to
5a5c78a
Compare
oxy
reviewed
Mar 11, 2021
jsjoeio
force-pushed
the
jsjoeio-2646-separate-testing
branch
from
5a5c78a to
7e23575
Compare
Merged
jsjoeio
added
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2646 by separating unit and e2e testing. Hopefully this speeds things up with CI.