Skip to content

fix(ci): add step to remove docker images on linux-arm64 #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2021
Merged

fix(ci): add step to remove docker images on linux-arm64 #2804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
471c6ff
fix(ci): remove release and test artifacts as a step
jsjoeio Mar 1, 2021
5e08d7f
fix(ci): remove docker images in linux-arm64
jsjoeio Mar 1, 2021
90807e1
fix(ci): replace extension in test standalone
jsjoeio Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(ci): replace extension in test standalone
  • Loading branch information
@jsjoeio
jsjoeio committed Mar 2, 2021
commit 90807e19e77eb7f99474ea274dade7f791f64071
4 changes: 1 addition & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,7 @@ jobs:
name: release-packages
path: ./release-packages
- name: Remove docker images
run: |
docker rm $(docker ps -aq)
docker rmi $(docker images -q)
run: docker system prune -af

macos-amd64:
needs: release
Expand Down
7 changes: 4 additions & 3 deletions ci/build/test-standalone-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@ main() {

echo "Testing standalone release."

./release-standalone/bin/code-server --extensions-dir "$EXTENSIONS_DIR" --install-extension ms-python.python
# Note: using a basic theme extension because it doesn't update often and is more reliable for testing
./release-standalone/bin/code-server --extensions-dir "$EXTENSIONS_DIR" --install-extension wesbos.theme-cobalt2
local installed_extensions
installed_extensions="$(./release-standalone/bin/code-server --extensions-dir "$EXTENSIONS_DIR" --list-extensions 2>&1)"
# We use grep as ms-python.python may have dependency extensions that change.
if ! echo "$installed_extensions" | grep -q "ms-python.python"; then
# We use grep as wesbos.theme-cobalt2 may have dependency extensions that change.
if ! echo "$installed_extensions" | grep -q "wesbos.theme-cobalt2"; then
echo "Unexpected output from listing extensions:"
echo "$installed_extensions"
exit 1
Expand Down