Skip to content

vscode: Show notification when upgrade is available #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2020
Merged

vscode: Show notification when upgrade is available #2358

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb63c0c
vscode: Show notification when upgrade is available
nhooyr Nov 24, 2020
f74f172
doc: Add note on upgrading into release notes and install.md
nhooyr Nov 24, 2020
be37821
update.ts: Simplify comparison
nhooyr Nov 24, 2020
37c80c9
vscode: Add missing semicolons
nhooyr Nov 24, 2020
def8124
vscode: Check updates with absolute path
nhooyr Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
vscode: Add missing semicolons 
See #2359
  • Loading branch information
@nhooyr
nhooyr committed Nov 24, 2020
commit 37c80c9bbd4a01ce0dabbd010b3b73831af9d3db
10 changes: 5 additions & 5 deletions ci/dev/vscode.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ index 096b9e23493539c9937940a56e555d95bbae38d9..ef37e614004f550f7b64eacd362f6894
remove(key: string, scope: StorageScope): void {
diff --git a/src/vs/server/browser/client.ts b/src/vs/server/browser/client.ts
new file mode 100644
index 0000000000000000000000000000000000000000..667ca961830feaf6fc5e5bb7ef2df3b8be97b176
index 0000000000000000000000000000000000000000..c6eef331346ebc244a26e8b1e5919d192225b971
--- /dev/null
+++ b/src/vs/server/browser/client.ts
@@ -0,0 +1,237 @@
Expand Down Expand Up @@ -924,7 +924,7 @@ index 0000000000000000000000000000000000000000..667ca961830feaf6fc5e5bb7ef2df3b8
+ }
+
+ const logService = (services.get(ILogService) as ILogService);
+ const storageService = (services.get(IStorageService) as IStorageService)
+ const storageService = (services.get(IStorageService) as IStorageService);
+ const getUpdate = async (): Promise<void> => {
+ logService.debug("Checking for update...");
+
Expand All @@ -945,7 +945,7 @@ index 0000000000000000000000000000000000000000..667ca961830feaf6fc5e5bb7ef2df3b8
+ const lastNoti = storageService.getNumber("csLastUpdateNotification", StorageScope.GLOBAL);
+ if (lastNoti) {
+ // Only remind them again after two days.
+ const timeout = 1000*60*24*2
+ const timeout = 1000*60*24*2;
+ const threshold = lastNoti + timeout;
+ if (Date.now() < threshold) {
+ return;
Expand Down Expand Up @@ -3906,15 +3906,15 @@ index 738ce140c1af76ee0017c59cc883578e966f5348..80833b7023ed5795bb3de303b54ec08d

.monaco-workbench .part.editor > .content .welcomePage .splash ul {
diff --git a/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts b/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts
index 4a61a79fe447e2aa238af568791bff1e0cec4d29..791b63342f476f1baba9d31b040d3ef589e3f70a 100644
index 4a61a79fe447e2aa238af568791bff1e0cec4d29..69cc2e4331a3b04d05d79632920f5c5bbfa924e8 100644
--- a/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts
+++ b/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts
@@ -328,7 +328,7 @@ class WelcomePage extends Disposable {

const prodName = container.querySelector('.welcomePage .title .caption') as HTMLElement;
if (prodName) {
- prodName.textContent = this.productService.nameLong;
+ prodName.textContent = `code-server v${this.productService.codeServerVersion}`
+ prodName.textContent = `code-server v${this.productService.codeServerVersion}`;
}

recentlyOpened.then(({ workspaces }) => {
Expand Down