Skip to content

Update VS Code to 1.51.1 #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 19, 2020
Merged

Update VS Code to 1.51.1 #2340

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e28c9ab
Update VS Code to 1.51.1
code-asher Nov 7, 2020
4d276b8
Add new logger service
code-asher Nov 7, 2020
431137d
Add new (unimplemented) terminal service
code-asher Nov 13, 2020
3f7b91e
Implement most of remote terminal service
code-asher Nov 17, 2020
4de2511
Implement terminal replay event
code-asher Nov 17, 2020
8311cf5
Handle non-persistent terminals
code-asher Nov 17, 2020
182aca6
Only replay terminals when detached
code-asher Nov 19, 2020
1feb30a
Send back workspace ID and name in terminal list
code-asher Nov 19, 2020
a6f8840
Add timeout for disposing detached terminals
code-asher Nov 19, 2020
8ffe599
Add notes on unimplemented terminal events
code-asher Nov 19, 2020
fa59156
Implement remaining resolver methods
code-asher Nov 19, 2020
d0f6cbb
Use resolverEnv to get exec path
code-asher Nov 19, 2020
42390da
Don't persist terminals for now
code-asher Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle non-persistent terminals
  • Loading branch information
@code-asher
code-asher committed Nov 19, 2020
commit 8311cf5657c7264c71373f1f15e0016da9336364
10 changes: 10 additions & 0 deletions ci/dev/vscode.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1880,6 +1880,7 @@ index 0000000000000000000000000000000000000000..cb3a45fda10a6bcbff73275b5734641b
+ private _title: string = "";
+ public readonly workspaceId: string;
+ public readonly workspaceName: string;
+ private readonly persist: boolean;
+
+ private readonly _onDispose = new Emitter<void>();
+ public get onDispose(): Event<void> { return this._onDispose.event; }
Expand Down Expand Up @@ -1918,6 +1919,13 @@ index 0000000000000000000000000000000000000000..cb3a45fda10a6bcbff73275b5734641b
+ data: this.replayData.join(""),
+ }]
+ });
+ },
+
+ onLastListenerRemove: () => {
+ logger.debug('Terminal unbound', field('id', this.id));
+ if (!this.persist) { // Used by debug consoles.
+ this.dispose();
+ }
+ }
+ });
+
Expand Down Expand Up @@ -1979,6 +1987,8 @@ index 0000000000000000000000000000000000000000..cb3a45fda10a6bcbff73275b5734641b
+ this.cols = args.cols;
+ this.rows = args.rows;
+
+ this.persist = args.shouldPersistTerminal;
+
+ this.process = new TerminalProcess(
+ config,
+ config.cwd,
Expand Down