Skip to content

Fix package step #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2020
Merged

Fix package step #1931

merged 2 commits into from
Jul 31, 2020

Conversation

code-asher
Copy link
Member

No description provided.

@code-asher code-asher requested a review from nhooyr as a code owner July 30, 2020 22:05
nhooyr
nhooyr reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Let's add a comment re the rimraf move into dependencies.

iirc we can use a key like dependencies_comment in package.json.

Just don't want someone else in the future to be confused.

@code-asher
Copy link
Member Author

Good point!

@code-asher
Move rimraf to prod deps in extensions
50ed29e 
The postinstall uses rimraf so it needs to exist in the final build.
@code-asher
Remove broken symlinks in extensions node modules
b63cf19 
The broken symlinks cause nfpm to fail.
@code-asher code-asher merged commit eccaf8e into master Jul 31, 2020
@code-asher code-asher deleted the rimraf branch July 31, 2020 17:25
@code-asher code-asher mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @nhooyr