Unable to install as PWA after logo update

[jichu4n]

Is there an existing issue for this?

• I have searched the existing issues

OS/Web Information

• Web Browser: Chrome
• Local OS: Linux
• Remote OS: Linux
• Remote Architecture: amd64
• code-server --version: 4.101.2 aff005e with Code 1.101.2

Steps to Reproduce

1. Open code-server instance in Chrome. My Chrome has version 138.0.7204.92.

Expected

There should be an "install" button in address bar that allows installing as PWA.

Actual

No "install" button appears in address bar:

Logs

Screenshot/Video

Error in Developer Tools > Application > Manifest:

Does this bug reproduce in native VS Code?

This cannot be tested in native VS Code

Does this bug reproduce in GitHub Codespaces?

No, this works as expected in GitHub Codespaces

Are you accessing code-server over a secure context?

• I am using a secure context.

Notes

Based on the error in DevTools, the issue is the line purpose: "maskable" added to manifest.json in src/node/routes/vscode.ts in this commit.

Removing this line locally (i.e. no purpose property set) fixes the issue. The "install" button appears as expected and allows installation as PWA. However not sure if that is the right fix as I assume the purpose: "maskable" line was added for a reason!