[Bug]: Terminal doesn't show after getting hidden. Only happened on firefox.

[yokowasis]

Is there an existing issue for this?

• I have searched the existing issues

OS/Web Information

• Web Browser: Firefox
• Local OS: 10
• Remote OS: Cloudlinux
• Remote Architecture: x64
• code-server --version: 4.0.1 735c6da

Steps to Reproduce

1. open code-server
2. open terminal using ctrl+`
3. press ctrl+` multiple times

Expected

The terminal should be shown and hidden, back and forth.

Actual

The terminal goes showing, and then hidden, and then never shown again.

This happened only on firefox, chrome works fine.

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code?

• I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

• I am using HTTPS.

Notes

No response

[jsjoeio]

Do you know which command that corresponds to? I must have overridden it.

I wonder what could be happening in Firefox 🤔 I've had some VS Code keybindings conflict with global Firefox shortcuts (like the one to open the Command Palette).

Does this bug still happen if you change the keybinding to something else?

[yokowasis]

Command : View: Toggle Terminal
Keybinding : ctrl + `
When : terminal.active
Source : default

Sorry for the late repy

[yokowasis]

I wonder what could be happening in Firefox 🤔 I've had some VS Code keybindings conflict with global Firefox shortcuts (like the one to open the Command Palette).

Does this bug still happen if you change the keybinding to something else?

This have nothing to do with keybinding, the same bug happened when using the command from Menu > View > Terminal

[jsjoeio]

Can you reproduce this in VS Code? For me, it does.

When I hit the same "View: Toggle Terminal" multiple times, nothing happens.

Video

Screen.Recording.2022-03-10.at.11.27.25.AM.mov

[yokowasis]

Can you reproduce this in VS Code? For me, it does.

When I hit the same "View: Toggle Terminal" multiple times, nothing happens.

Video

Screen.Recording.2022-03-10.at.11.27.25.AM.mov

Exactly, the right behaviour would be the terminal would be toggled between shown and hidden. sometimes it would be hidden and wouldn't be shown. sometimes it would be shown and woudn't be hidden.

In desktop vscode and chrome, it works as expected. each time I run the command, the terminal would be toggled.

[jsjoeio]

Exactly, the right behaviour would be the terminal would be toggled between shown and hidden. sometimes it would be hidden and wouldn't be shown. sometimes it would be shown and woudn't be hidden.

Yup! I understand that. This video is VS Code and the behavior is the exact same there as it is here.

In desktop vscode and chrome, it works as expected. each time I run the command, the terminal would be toggled.

Can you post a video?

[yokowasis]

Desktop VSCode Behaviour

vscode.mp4

code-server behaviour (only on firefox)

codeserver.mp4

The command is not Terminal: Focus Terminal, it's View: Toggle Terminal

[jsjoeio]

I was able to reproduce it locally on macOS + Firefox + code-server 4.10.0