Terminal Persistence strips terminal names

OS/Web Information

• Web Browser: Opera GX
• Local OS: Windows 10
• Remote OS: Ubuntu 20.04
• Remote Architecture: 64-bit
• code-server --version: 3.10.0

Steps to Reproduce

1. Make multiple terminals
2. Rename one or all of them
3. Reload the page
4. Names are now invisible

Expected

The names persist and continue showing

Actual

The names disappear and become invisible (buttons can still be clicked although invisible). Its worth noting the actual name resets too, for example back to "bash" on reload and then turns invisible

Logs

Screenshot

https://brandentheprogrammer.is-terrible.com/wI5eJY.png

Notes

This issue can be reproduced in VS Code: Unsure

Edit by @code-asher: invisible names might require enabling terminal tabs first, see #3454.

[jsjoeio]

The names are not invisible when I try to reproduce this locally, but they're also not persisting 🤔
Env: code-server 3.10.0, macOS, Chrome

Screen.Recording.2021-05-11.at.10.53.18.AM.mov

We'll have to investigate this.

logs

[2021-05-11T17:50:20.891Z] info  code-server 3.10.0 f9b6d04cab0463c487e0390fc73e902e1f83a99e
[2021-05-11T17:50:20.892Z] info  Using user-data-dir ~/.local/share/code-server
[2021-05-11T17:50:20.943Z] info  Using config file ~/.config/code-server/config.yaml
[2021-05-11T17:50:20.943Z] info  HTTP server listening on http://127.0.0.1:8080 
[2021-05-11T17:50:20.943Z] info    - Authentication is disabled 
[2021-05-11T17:50:20.943Z] info    - Not serving HTTPS 
[IPC Library: Pty Host]  INFO Persistent process "2": Replaying 523 chars and 3 size events
[IPC Library: Pty Host]  INFO Persistent process "4": Replaying 260 chars and 1 size events

[jsjoeio]

@marsinearth please open a separate bug report issue!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

[code-asher]

This should be fixed in 4.0.0.