--reuse-window not working

[hsharrison]

I'm trying to use the new feature --reuse-window but it just opens a new instance:

[~] : touch test
[~] : code-server --reuse-window test
[2020-09-14T21:13:58.914Z] info  Using config file ~/.config/code-server/config.yaml
[2020-09-14T21:13:59.548Z] info  Using user-data-dir ~/.local/share/code-server
[2020-09-14T21:13:59.587Z] info  code-server 3.5.0 de41646fc402b968ca6d555fdf2da7de9554d28a
[2020-09-14T21:13:59.625Z] info  HTTP server listening on http://127.0.0.1:8080
[2020-09-14T21:13:59.627Z] info      - Using password from ~/.config/code-server/config.yaml
[2020-09-14T21:13:59.628Z] info      - To disable use `--auth none`
[2020-09-14T21:13:59.629Z] info    - Not serving HTTPS

Any ideas? As far as I can tell from the docs this should open the file in the existing instance.

[code-asher]

Are you running it inside code-server's terminal? Right now it only works there but we're working on making it work externally as well: #2036

[hsharrison]

Ah, I didn't realize that, thanks! I suppose the docs could be more clear on that point (also side comment but I just noticed the help message still references --open-in which I think was not merged in the end).

[code-asher]

Good catch! I'll remove the --open-in references when implementing #2036.

Definitely a fair point on the docs. If #2036 doesn't make it into the next release I'll add some text about not working externally.