Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stand-alone spawner service; remove proxy and nginx #493

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Aug 30, 2023

This is a major refactor, mostly around how runtimes are spawned. The new architecture is pictured below.

  • The system now consists of 4 services: UI, API, Yjs, Spawner
  • Notable, a new "spawner" service unifies the runtime-related pieces previously spread across api/proxy/yjs.
Screenshot 2023-08-29 at 7 14 43 PM

Change to development workflow:

  • Now, nginx is removed. You no longer to go to http://localhost:8080 to see the app.
  • Instead, the services now explicitly binds to host port (see compose.yml file for 4 ports bindings). Use http://localhost:3000 to access the app.

@lihebi lihebi changed the title refactor: arch with stand-alone spawner server; remove proxy and nginx refactor: stand-alone spawner service; remove proxy and nginx Aug 30, 2023
@lihebi lihebi merged commit ed3efe0 into codepod-io:main Aug 30, 2023
@senwang86
Copy link
Collaborator

Awesome change to simplify the development stack ! 🚀 🚀

senwang86 pushed a commit to senwang86/codepod that referenced this pull request Aug 31, 2023
@lihebi lihebi added the major label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants