remove state.pods; fix runtime & results #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senwang86
reviewed
Aug 14, 2023
Comment on lines
+883
to
+884
| const podResults = useStore(store, (state) => state.podResults); | ||
| const codeMap = useStore(store, (state) => state.getCodeMap()); |
There was a problem hiding this comment.
Is the podResults not synced with YJS by design? @lihebi
There was a problem hiding this comment.
It should be saved to Yjs. It's on my TODO list.
There was a problem hiding this comment.
It should be saved to Yjs. It's on my TODO list.
Is there any concern to append podResults to codeMap?
There was a problem hiding this comment.
That's an option; I'm thinking about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up PR for #440 to fix broken things.
What's changed:
Remaining TODOs regarding this centered-Yjs transition: