[UI] Support exporting pod stdout and result#399
Merged
lihebi merged 2 commits intocodepod-io:mainfrom Jul 28, 2023
Merged
Conversation
lihebi
reviewed
Jul 28, 2023
ui/src/components/Sidebar.tsx
Outdated
| "href", | ||
| "data:text/plain;charset=utf-8," + encodeURIComponent(data.exportJSON) | ||
| ); | ||
| element.setAttribute("download", `${repoName || ""}.json`); |
Collaborator
There was a problem hiding this comment.
Let's add date to the exported filename and keep consistent with the .ipynb export.
codepod/ui/src/components/Sidebar.tsx
Lines 891 to 893 in 554cdac
Collaborator
There was a problem hiding this comment.
Nevermind, I made this minor change. Merging.
| cellType: cell.cell_type, | ||
| cellSource: cell.source.join(""), | ||
| cellOutputs: cell.outputs || [], | ||
| execution_count: cell.execution_count || 0, |
Collaborator
There was a problem hiding this comment.
We should display the execution count in the output area of a Code pod. This PR already gets packed, let's implement it in another PR.
Collaborator
There was a problem hiding this comment.
execution_count is a property of both a code cell and its output (if the output type is execute_result) #411
Collaborator
|
Thanks, Sen! |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test