Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remirror toolbar position when panning on canvas #346

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix remirror toolbar position when panning on canvas #346

merged 1 commit into from
Jun 28, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Jun 28, 2023 •
edited
Loading

New behaviors:

  1. the remirror floating toolbar will follow the Rich-text pod when panning on canvas.
  2. it will disappear when you click on the canvas

(minor) Also fixed an issue that prevented canvas-panning when mouse is over the remirror toolbar.

Screen.Recording.2023-06-28.at.10.35.19.AM.mov

@lihebi lihebi changed the title fix remirror toolbar position when pane on canvas fix remirror toolbar position when pan on canvas Jun 28, 2023
@lihebi lihebi changed the title fix remirror toolbar position when pan on canvas fix remirror toolbar position when panning on canvas Jun 28, 2023
@lihebi lihebi merged commit 0668828 into codepod-io:main Jun 28, 2023
li-xin-yi pushed a commit to li-xin-yi/codepod-1 that referenced this pull request Jul 4, 2023
@lihebi @li-xin-yi
fix remirror toolbar position when panning on canvas (codepod-io#346)
fed8011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lihebi