Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor zustand store #185

Merged
merged 1 commit into from
Dec 27, 2022
Merged

refactor zustand store #185

merged 1 commit into from
Dec 27, 2022

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Dec 27, 2022 •
edited
Loading

  • Split the store into many small slices.
  • Move large action functions out so that createXXXStore can be concise.
  • Cleanup deprecated functions (e.g., old import/exports related ones, computeNamespace)

@lihebi lihebi merged commit 9dc2fdb into main Dec 27, 2022
@li-xin-yi
Copy link
Collaborator

We may also need to refactor Canvas.tsx, move the definition of codeNode and scopeNode into components/nodes. Canvas.tsx is also too heavy, it's painful to code on it. 😭

@lihebi
Copy link
Collaborator Author

lihebi commented Dec 28, 2022

Yep, I'm working on refactoring Canvas.

@lihebi lihebi deleted the refactor-store branch June 30, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lihebi @li-xin-yi