Skip to content

Updating SYCL For CUDA examples to CUDA 12 and latest intel llvm tip #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 19, 2023

Conversation

Ruyk
Copy link
Contributor

@Ruyk Ruyk commented Feb 13, 2023

  • Updating SGEMM interop for CUDA 12 and context interop changes
  • Updating vector addition to CUDA 12
  • Updating both to SYCL 2020 modern syntax

Ruyk added 5 commits February 9, 2023 16:44
Works with latest DPC++ and SYCL2020 features
README updated to reflect CUDA backend has USM support
Since intel/llvm#8197, SYCL CUDA backend uses
CUDA primary context by default, so individual context setting is no
longer required.
SYCL 1.2.1 device selectors have been deprecated in favour of a new
simplified form using lambdas.
Run clang-format on files, separate commit to avoid noise
@Ruyk Ruyk requested a review from joeatodd February 13, 2023 12:17
@Ruyk Ruyk self-assigned this Feb 13, 2023
Copy link

@AerialMantis AerialMantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ruyk added 2 commits April 19, 2023 17:13
Because of the changes on SYCL context, it is necessary now to set the
active CUDA context manually inside the host task.

Note there was some clang-formatting here as well
Copy link

@AerialMantis AerialMantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@Ruyk Ruyk merged commit 6bf6411 into master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants