[SYCL] Initial commit of interop example #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruyman Reyes <ruyman@codeplay.com>
ProGTX
reviewed
May 7, 2020
example-02/sycl_sgemm.cpp
Outdated
| const size_t WIDTH = 1024; | ||
| const size_t HEIGHT = 1024; | ||
| const float ALPHA = 1.0f; | ||
| const float BETA = 0.0f; |
ProGTX
reviewed
May 7, 2020
example-02/sycl_sgemm.cpp
Outdated
| h.interop_task([=](sycl::interop_handler ih) { | ||
| cublasSetStream(handle, ih.get_queue<backend::cuda>()); | ||
|
|
||
| float *cuA = reinterpret_cast<float *>(ih.get_mem<backend::cuda>(d_A)); |
There was a problem hiding this comment.
What's the native handle for CUDA memory? Could you use a static_cast instead? Also you can use auto instead of float* since you already specify the exact type with the cast.
There was a problem hiding this comment.
CUdeviceptr is the native type but is not used in CUDA Runtime API, just using the pointer is enough. Cannot static cast because it converts a number into a pointer
ProGTX
reviewed
May 7, 2020
ProGTX
reviewed
May 7, 2020
example-02/sgemm.cu
Outdated
| const size_t WIDTH = 1024; | ||
| const size_t HEIGHT = 1024; | ||
| const float ALPHA = 1.0f; | ||
| const float BETA = 0.0f; |
ProGTX
reviewed
May 7, 2020
| @@ -0,0 +1,32 @@ | |||
| cmake_minimum_required(VERSION 3.17 FATAL_ERROR) | |||
There was a problem hiding this comment.
Why is CMake 3.17 such a strong requirement?
There was a problem hiding this comment.
The
find_package(CUDAToolkit)used below simplifies the setting up of the project, but is only available on latest cmake.
ProGTX
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of using interop task to use CUBLAS from SYCL