Skip to content

Update CUDA examples to work with recent DPC++ #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Conversation

Ruyk
Copy link
Contributor

@Ruyk Ruyk commented Dec 15, 2020

No description provided.

@Ruyk Ruyk requested a review from nyalloc December 15, 2020 11:38
@Ruyk Ruyk self-assigned this Dec 15, 2020
Copy link
Contributor

@nyalloc nyalloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

auto cuA = reinterpret_cast<float *>(ih.get_mem<backend::cuda>(d_A));
auto cuB = reinterpret_cast<float *>(ih.get_mem<backend::cuda>(d_B));
auto cuC = reinterpret_cast<float *>(ih.get_mem<backend::cuda>(d_C));
h.codeplay_host_task([=](sycl::interop_handle ih) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a handler that is called "codeplay_host_task" ? Why is it not just host_task?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a codeplay extension implemented by DPC++, rather than the SYCL 2020 feature, and that is how it is defined.

@Ruyk Ruyk merged commit 1416d9e into master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants