Skip to content

Subpath highlighting fix with empty url #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2017

Conversation

ilyapoz
Copy link
Contributor

@ilyapoz ilyapoz commented Mar 19, 2017

close #188

@ilyapoz
Copy link
Contributor Author

ilyapoz commented Mar 19, 2017

You guys have some problems with travis build, I'm quite new to ruby still, so wasn't able to quickly resolve it. I did manage to run tests locally.

@ilyapoz ilyapoz changed the title Subpath highlighting fix Subpath highlighting fix with empty url Mar 19, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0008%) to 99.616% when pulling ed73c77 on ilyapoz:subpath-highlighting-fix into 90dcb19 on codeplant:master.

@andi andi merged commit 1bbb790 into codeplant:master Mar 20, 2017
@andi
Copy link
Collaborator

andi commented Mar 20, 2017

Yeah travis build is an issue currently, did not have time yet to investigate...

@ilyapoz
Copy link
Contributor Author

ilyapoz commented Mar 20, 2017

It breaks locally in the same way. If some time soon I will dig into testing gems I might send a pr.

@ilyapoz ilyapoz deleted the subpath-highlighting-fix branch March 20, 2017 09:46
@andi
Copy link
Collaborator

andi commented Mar 20, 2017

I guess I fixed the travis build. default rake task was spec:all which loops through all versions, this does not make sense for travis...

@andi
Copy link
Collaborator

andi commented Mar 20, 2017

released 4.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank url and highligh_on_subpath = true causes error.
3 participants