This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Make the output of the requirement file generator determinable #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I recompile the api the order of the generated requirements almost always change. Over time someone would have probably accidentally committed a reorder, ending in useless commits. A fix for this is to order all input files, which will always result in the same output.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I recompile the api the order of the generated requirements almost always change.
These changes can accidentally be committed like in codeoverflow-org/chatoverflow-api@4bf446b. There the requirement file of the inputs has changed, but those are just reorderings.
A fix for this is to order all input files, which will always result in the same output.