Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Commit 2cde2f9

Browse files
committed
Updated all remaining TODOs.
1 parent ffc462c commit 2cde2f9

File tree

7 files changed

+1
-39
lines changed

7 files changed

+1
-39
lines changed

src/main/scala/org/codeoverflow/chatoverflow/connector/ConnectorRegistry.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ object ConnectorRegistry extends WithLogger {
4141
logger warn "Unable to remove connector. Connector is running."
4242
false
4343
} else {
44-
// TODO: Check if this might crash anything
4544
connectors -= connectorKey
4645
true
4746
}

src/main/scala/org/codeoverflow/chatoverflow/connector/actor/FileSystemActor.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import scala.io.Source
1515
*/
1616
class FileSystemActor extends Actor {
1717

18-
// TODO: Should be tested
1918
private val dataFilePath = Launcher.pluginDataPath
2019

2120
// Create data folder if non existent

src/main/scala/org/codeoverflow/chatoverflow/framework/helper/PluggableLoader.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ class PluggableLoader(classLoader: ClassLoader) extends WithLogger {
2525
// Now: Try to instantiate the pluggable class
2626
val pluggableObjects = createPluggableObjects(pluggableClasses)
2727

28-
// TODO: Are more than 1 implementation of pluggable allowed / possible / useful
2928
pluggableObjects.length match {
3029
case 0 => logger warn "No pluggable classes found."
3130
case 1 =>

src/main/scala/org/codeoverflow/chatoverflow/registry/TypeRegistry.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class TypeRegistry(requirementPackage: String) extends WithLogger {
5353
connectorTypes.clear()
5454

5555
// Use reflection magic to get all impl-annotated classes
56-
// FIXME: Does also find definitions not in the exact package - no problem right now
56+
// FIXME: Does also find definitions not in the exact package - not intended should be filtered afterwards
5757
val reflections: Reflections = new Reflections(new ConfigurationBuilder()
5858
.setUrls(ClasspathHelper.forPackage(requirementPackage))
5959
.setScanners(new SubTypesScanner(), new TypeAnnotationsScanner()))

src/main/scala/org/codeoverflow/chatoverflow/requirement/service/file/FileConnector.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ class FileConnector(override val sourceIdentifier: String) extends Connector(sou
2828
}
2929
}
3030

31-
// TODO: Save / Load XML
32-
3331
def saveFile(pathInResources: String, content: String): Boolean = fileActor.??[Boolean](5){SaveFile(pathInResources, content)}.get
3432

3533
def saveBinaryFile(pathInResources: String, content: Array[Byte]): Boolean = fileActor.??[Boolean](5){SaveBinaryFile(pathInResources, content)}.get

src/main/scala/org/codeoverflow/chatoverflow/requirement/service/tipeeestream/TipeeeStreamConnector.scala

Lines changed: 0 additions & 19 deletions
This file was deleted.

src/main/scala/org/codeoverflow/chatoverflow/requirement/service/tipeeestream/impl/TipeeeStreamInputImpl.scala

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)