Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Commit ffc462c

Browse files
committed
Changed plugin sbt file name generation, updated TODOs.
1 parent 99eef13 commit ffc462c

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

project/BuildUtility.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,9 @@ class BuildUtility(logger: ManagedLogger) {
150150
def createPluginTask(pluginFolderNames: List[String]): Unit = {
151151
withTaskInfo("CREATE PLUGIN") {
152152

153+
// TODO: Generated plugin structure should contain ready-to-implement files
154+
// TODO: BuildUtility / Build Environment should be refactored to enable separate plugin dev environments with a subset of sbt functionality
155+
153156
// Plugin folders have to be defined in the build.sbt file first
154157
if (pluginFolderNames.isEmpty) {
155158
println("Before creating a new plugin, please define at least one plugin source folder in the build.sbt file.")

project/Plugin.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ class Plugin(val pluginSourceDirectoryName: String, val name: String) {
5151
def createSbtFile(version: String): Boolean = {
5252
val sbtFile = new SbtFile(name, version)
5353

54-
// TODO: Check if build.sbt can be named $pluginName.sbt
55-
sbtFile.save(s"$pluginDirectoryPath/build.sbt")
54+
// The name of the sbt file is the plugin name. This worked in first tests
55+
sbtFile.save(s"$pluginDirectoryPath/$name.sbt")
5656
}
5757

5858
/**

src/main/scala/org/codeoverflow/chatoverflow/Launcher.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ object Launcher extends WithLogger {
4949
}
5050
}
5151

52+
// TODO: Delete REPL, update CLI, update wiki
53+
5254
// Launch UI
5355
config.ui match {
5456
case UI.GUI =>

src/main/scala/org/codeoverflow/chatoverflow/ui/CLI.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ object CLI {
8585
startupPlugins: Seq[String] = Seq[String]())
8686

8787
// TODO: Fix path layout
88-
// TODO: Remove UI flag, remove REPL
8988

9089
object UI extends Enumeration {
9190
type UI = Value

src/main/scala/org/codeoverflow/chatoverflow/ui/repl/REPL.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,6 @@ class REPL(chatOverflow: ChatOverflow) {
135135
.map(inst => inst.instanceName).mkString(", "))
136136
}
137137

138-
// TODO: Enable shutting down everything correctly by function call
139-
// TODO: Proper repl ask function... i mean... why?
140-
// TODO: Add more functionality
141-
142138
private def help(): Unit = {
143139
println("Available commands:\n")
144140
commands.foreach(cmd => println(s"${cmd._1}:\t${cmd._2.description}"))

0 commit comments

Comments
 (0)