Removed Errorhandling and removed some useless lines

Author: derNiklaas

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/BooleanParameterImpl.scala

@@ -17,9 +17,7 @@ class BooleanParameterImpl extends BooleanParameter {
 
   override def get(): Boolean = value
 
-  override def deserialize(value: String): Unit = {
-    set(Boolean.parseBoolean(value))
-  }
+  override def deserialize(value: String): Unit = set(Boolean.parseBoolean(value))
 
   override def set(value: Boolean): Unit = this.value = value
 

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/ColorParameterImpl.scala

@@ -18,34 +18,30 @@ class ColorParameterImpl extends ColorParameter {
   override def get(): Color = value
 
   override def deserialize(value: String): Unit = {
-
     val hex3 = "^#([a-fA-F0-9]{6})$".r // Test if the value contains # and then 6 hexadecimal numbers
     val hex4 = "^#([a-fA-F0-9]{8})$".r // Test if the value contains # and then 8 hexadecimal numbers
     val int3 = "^(\\d+),(\\d+),(\\d+)$".r //Test if the value contains 3 ints
     val int4 = "^(\\d+),(\\d+),(\\d+),(\\d+)$".r //Test if the value contains 4 ints
     val float3 = "^(\\d+(?:\\.\\d+)?),(\\d+(?:\\.\\d+)?),(\\d+(?:\\.\\d+)?)$".r //Test if the value contains 3 floats
     val float4 = "^(\\d+(?:\\.\\d+)?),(\\d+(?:\\.\\d+)?),(\\d+(?:\\.\\d+)?),(\\d+(?:\\.\\d+)?)$".r //Test if the value contains 4 floats
 
-    try {
-      value match {
-        case hex3(hex) => {
-          set(new Color(Integer.valueOf(hex.substring(0, 2), 16),
-            Integer.valueOf(hex.substring(2, 4), 16),
-            Integer.valueOf(hex.substring(4, 6), 16)))
-        }
-        case hex4(hex) =>
-          set(new Color(Integer.valueOf(hex.substring(0, 2), 16),
-            Integer.valueOf(hex.substring(2, 4), 16),
-            Integer.valueOf(hex.substring(4, 6), 16),
-            Integer.valueOf(hex.substring(6, 8), 16)))
-        case int3(r, g, b) => set(new Color(r.toInt, g.toInt, b.toInt))
-        case int4(r, g, b, a) => set(new Color(r.toInt, g.toInt, b.toInt, a.toInt))
-        case float3(r, g, b) => set(new Color(r.toFloat, g.toFloat, b.toFloat))
-        case float4(r, g, b, a) => set(new Color(r.toFloat, g.toFloat, b.toFloat, a.toFloat))
+    value match {
+      case hex3(hex) => {
+        set(new Color(Integer.valueOf(hex.substring(0, 2), 16),
+          Integer.valueOf(hex.substring(2, 4), 16),
+          Integer.valueOf(hex.substring(4, 6), 16)))
       }
-    } catch {
-      case _: Exception => print("Can't convert String to color")
+      case hex4(hex) =>
+        set(new Color(Integer.valueOf(hex.substring(0, 2), 16),
+          Integer.valueOf(hex.substring(2, 4), 16),
+          Integer.valueOf(hex.substring(4, 6), 16),
+          Integer.valueOf(hex.substring(6, 8), 16)))
+      case int3(r, g, b) => set(new Color(r.toInt, g.toInt, b.toInt))
+      case int4(r, g, b, a) => set(new Color(r.toInt, g.toInt, b.toInt, a.toInt))
+      case float3(r, g, b) => set(new Color(r.toFloat, g.toFloat, b.toFloat))
+      case float4(r, g, b, a) => set(new Color(r.toFloat, g.toFloat, b.toFloat, a.toFloat))
     }
+
   }
 
   override def set(value: Color): Unit = this.value = value

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/DoubleParameterImpl.scala

@@ -18,13 +18,7 @@ class DoubleParameterImpl extends DoubleParameter {
 
   override def get(): Double = value
 
-  override def deserialize(value: String): Unit = {
-    try {
-      set(Double.valueOf(value))
-    } catch {
-      case _: Exception => print("Can't convert String to double")
-    }
-  }
+  override def deserialize(value: String): Unit = set(Double.valueOf(value))
 
   override def set(value: Double): Unit = this.value = value
 }

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/IntegerParameterImpl.scala

@@ -16,13 +16,7 @@ class IntegerParameterImpl extends IntegerParameter {
 
   override def get(): Integer = value
 
-  override def deserialize(value: String): Unit = {
-    try {
-      set(Integer.valueOf(value))
-    } catch {
-      case _: Exception => print("Can't convert String to int")
-    }
-  }
+  override def deserialize(value: String): Unit = set(Integer.valueOf(value))
 
   override def set(value: Integer): Unit = this.value = value
 

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/ListParameterImpl.scala

@@ -13,15 +13,11 @@ class ListParameterImpl extends ListParameter {
 
   override def getType: Class[java.util.List[String]] = classOf[java.util.List[String]]
 
-  override def serialize(): String = {
-    value.mkString(",")
-  }
+  override def serialize(): String = value.mkString(",")
 
   override def get(): java.util.List[String] = value.asJava
 
-  override def deserialize(value: String): Unit = {
-    set(value.split(",").toSeq.asJava)
-  }
+  override def deserialize(value: String): Unit = set(value.split(",").toSeq.asJava)
 
   override def set(value: java.util.List[String]): Unit = this.value = value.asScala.toList
 }

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/MapParameterImpl.scala

@@ -14,18 +14,16 @@ class MapParameterImpl extends MapParameter {
 
   override def getType: Class[java.util.Map[String, String]] = classOf[java.util.Map[String, String]]
 
-  override def serialize(): String = {
-    value.map({ case (key, value) => s"($key;$value)" }).mkString(",")
-  }
+  override def serialize(): String = value.map({ case (key, value) => s"($key;$value)" }).mkString(",")
 
   override def get(): java.util.Map[String, String] = value.asJava
 
   override def deserialize(value: String): Unit = {
     val kvpair = "\\((.+);(.+)\\)".r
     val konly = "\\((.+);\\)".r
-    set(value.split(",")
+    this.value = value.split(",")
       .map({ case kvpair(k, v) => (k -> v); case konly(k) => (k -> ""); case _ => ("" -> "") })
-      .toMap.asJava)
+      .toMap
   }
 
   override def set(value: java.util.Map[String, String]): Unit = this.value = value.asScala.toMap