Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Commit e5bbc81

Browse files
committed
Changed internal List/Map type to scala
1 parent e688650 commit e5bbc81

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed
Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,27 @@
11
package org.codeoverflow.chatoverflow.requirement.parameter
22

3-
import java.util.List
4-
53
import collection.JavaConverters._
64
import org.codeoverflow.chatoverflow.api.io.parameter.ListParameter
75
import org.codeoverflow.chatoverflow.registry.Impl
86

9-
107
/**
118
* A parameter holding a List<String> value.
129
*/
1310
@Impl(impl = classOf[ListParameter])
1411
class ListParameterImpl extends ListParameter {
1512
private var value: List[String] = null
1613

17-
override def getType: Class[List[String]] = classOf[List[String]]
14+
override def getType: Class[java.util.List[String]] = classOf[java.util.List[String]]
1815

1916
override def serialize(): String = {
20-
value.asScala.mkString(",")
17+
value.mkString(",")
2118
}
2219

23-
override def get(): List[String] = value
20+
override def get(): java.util.List[String] = value.asJava
2421

2522
override def deserialize(value: String): Unit = {
2623
set(value.split(",").toSeq.asJava)
2724
}
2825

29-
override def set(value: List[String]): Unit = this.value = value
30-
26+
override def set(value: java.util.List[String]): Unit = this.value = value.asScala.toList
3127
}

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/MapParameterImpl.scala

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import org.codeoverflow.chatoverflow.registry.Impl
44
import org.codeoverflow.chatoverflow.api.io.parameter.MapParameter
55

66
import collection.JavaConverters._
7-
import java.util.Map
87

98
/**
109
* A parameter holding a Map<String, String> value.
@@ -13,13 +12,13 @@ import java.util.Map
1312
class MapParameterImpl extends MapParameter {
1413
private var value: Map[String, String] = null
1514

16-
override def getType: Class[Map[String, String]] = classOf[Map[String, String]]
15+
override def getType: Class[java.util.Map[String, String]] = classOf[java.util.Map[String, String]]
1716

1817
override def serialize(): String = {
19-
value.asScala.map({ case (key, value) => s"($key;$value)" }).mkString(",")
18+
value.map({ case (key, value) => s"($key;$value)" }).mkString(",")
2019
}
2120

22-
override def get(): Map[String, String] = value
21+
override def get(): java.util.Map[String, String] = value.asJava
2322

2423
override def deserialize(value: String): Unit = {
2524
val kvpair = "\\((.+);(.+)\\)".r
@@ -29,6 +28,6 @@ class MapParameterImpl extends MapParameter {
2928
.toMap.asJava)
3029
}
3130

32-
override def set(value: Map[String, String]): Unit = this.value = value
31+
override def set(value: java.util.Map[String, String]): Unit = this.value = value.asScala.toMap
3332

3433
}

0 commit comments

Comments
 (0)