Stabilize gradient and arc screenshot tests#4483
Closed
shai-almog wants to merge 1 commit intocodex/update-android-build-pipeline-to-api-level-36from
Closed
Stabilize gradient and arc screenshot tests#4483shai-almog wants to merge 1 commit intocodex/update-android-build-pipeline-to-api-level-36from
shai-almog wants to merge 1 commit intocodex/update-android-build-pipeline-to-api-level-36from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Graphicsgradient drawing inDrawGradientwith a deterministic pixel buffer via a newbuildGradientImagemethod and draw the cachedImageinstead.gradientImage,cachedWidth,cachedHeight) so the pixel buffer is rebuilt only when dimensions change.fillLinearGradient,fillRadialGradient,fillRectRadialGradient,blendColor,angleInArc) that produce consistent pixel output using integer RGB buffers andImage.createImage(int[], width, height).FillArcto compute arcwidth/heightfrombounds(rather than using coordinate arithmetic) and added a guard to stop when dimensions become non-positive before callingfillArc.Testing
mvn/CI runs were not requested).Codex Task