You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a way to control how links with target="_blank" / target="_new" are handled so navigation can be kept in the current browser view instead of opening a new window.
Expose this behavior as a browser property and default it to following such links (consistent with Android behavior).
Description
Add BrowserComponent.BROWSER_PROPERTY_FOLLOW_TARGET_BLANK and wire setBrowserProperty(...) to propagate the setting to platform implementations via setBrowserFollowTargetBlank.
iOS: add native void setBrowserFollowTargetBlank(...) in IOSNative.java, implement Objective-C helpers and a native setter in IOSNative.m (using associated objects) with default YES, and update UIWebView/WKWebView navigation handling in UIWebViewEventDelegate.m to loadRequest: and cancel the popup when targetFrame == nil and following is enabled.
JavaSE (JavaFX): add a followTargetBlank flag in SEBrowserComponent, register a setCreatePopupHandler(...) that returns the same WebEngine when following is enabled, and honor the property in setProperty.
JavaSE (CEF): add a followTargetBlank flag and expose setFollowTargetBlank(...) in BrowserPanel, handle onBeforePopup(...) in the CEF lifespan handler to load the target URL in the same browser when enabled, and wire CEFBrowserComponent.setProperty(...) to set the flag.
Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835. Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.
Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835. Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
target="_blank"/target="_new"are handled so navigation can be kept in the current browser view instead of opening a new window.Description
BrowserComponent.BROWSER_PROPERTY_FOLLOW_TARGET_BLANKand wiresetBrowserProperty(...)to propagate the setting to platform implementations viasetBrowserFollowTargetBlank.native void setBrowserFollowTargetBlank(...)inIOSNative.java, implement Objective-C helpers and a native setter inIOSNative.m(using associated objects) with defaultYES, and updateUIWebView/WKWebViewnavigation handling inUIWebViewEventDelegate.mtoloadRequest:and cancel the popup whentargetFrame == niland following is enabled.followTargetBlankflag inSEBrowserComponent, register asetCreatePopupHandler(...)that returns the sameWebEnginewhen following is enabled, and honor the property insetProperty.followTargetBlankflag and exposesetFollowTargetBlank(...)inBrowserPanel, handleonBeforePopup(...)in the CEF lifespan handler to load the target URL in the same browser when enabled, and wireCEFBrowserComponent.setProperty(...)to set the flag.Testing
Codex Task