Use explicit half-stroke inset for RoundRectBorder and update regression test to avoid reflection

[shai-almog]

Motivation

• Prevent asymmetric or excessive inset for rounded-rectangle borders when using odd-pixel stroke widths by applying the true half-stroke inset instead of an extra 0.5px adjustment.
• Improve the regression test by avoiding reflection and asserting rendering behavior through the existing test graphics implementation.

Description

• Replace the odd-pixel + 0.5f adjustment with an explicit float halfStroke = strokePx / 2f; and apply x += halfStroke; y += halfStroke; in CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java to inset shapes by the true half stroke.
• Remove the branch that added an additional 0.5f for odd strokePx values so only the true half-stroke inset is applied.
• Rewrite the regression unit test testRoundRectBorderOddStrokeInsetsEvenly in maven/core-unittests/src/test/java/com/codename1/ui/plaf/BorderAndPlafTest.java to instantiate a Label, set the RoundRectBorder, call paintBorderBackground on a test Graphics, use TestCodenameOneImplementation shape tracking (resetShapeTracking, wasDrawShapeInvoked, getLastDrawShape) and assert the recorded shape bounds rather than using reflection.

Testing

• No automated tests were executed as part of this change; the updated unit test was added/modified but not run.

---

Codex Task

[shai-almog]

Compared 30 screenshots: 30 matched.

Native Android coverage

• 📊 Line coverage: 24.87% (2665/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.48% (12367/50528), branch 15.35% (717/4672), complexity 17.54% (744/4241), method 33.08% (602/1820), class 34.98% (106/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

• 📊 Line coverage: 24.87% (2665/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.48% (12367/50528), branch 15.35% (717/4672), complexity 17.54% (744/4241), method 33.08% (602/1820), class 34.98% (106/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2283 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.79% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
    • com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

• ✅ SpotBugs: 0 findings (no issues) [Report archive]
• ❌ PMD: 478 findings (P2: 42, P3: 426, P4: 10) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/capture/Capture.java:252 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
    • P2: CodenameOne/src/com/codename1/compat/java/util/Objects.java:47 – The method name and parameter number are suspiciously close to equals(Object) (rule: SuspiciousEqualsMethodName)
    • P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:43 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
    • P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:44 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
    • P2: CodenameOne/src/com/codename1/io/BufferedInputStream.java:38 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
    • …and 473 more
• ❌ Checkstyle: 221053 findings (Warning: 221053) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 221048 more

Generated automatically by the PR CI workflow.

[shai-almog]

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

• BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

• graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

• graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

• graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

• graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
  Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

• graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

• kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 283 seconds
• Compilation Time: 209 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	24173 ms
Extract Extensions	12 ms
Google Services Setup	2 ms
Scan Classes	803 ms
Extract Libs	550 ms
Inject Build Hints	37 ms
Generate Unit Tests	3 ms
Generate Stubs	896 ms
Compile Stubs	1877 ms
Generate Icons	1091 ms
Prepare ParparVM	163 ms
ParparVM Execution	166857 ms
Post-VM Setup	274 ms
CocoaPods	5079 ms
Finalize	21 ms
Total Time	201839 msMaven Overhead : 82000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot	56000 ms
Simulator Boot (Run)	2000 ms
App Install	13000 ms
App Launch	6000 ms
Test Execution	144000 ms