Fix PMD EmptyControlStatement and ForLoopCanBeForeach violations and enforce them in quality report by shai-almog · Pull Request #4454 · codenameone/CodenameOne

shai-almog · 2026-01-21T18:17:19Z

Motivation

Remove numerous PMD EmptyControlStatement and ForLoopCanBeForeach violations across the codebase to improve code clarity and satisfy static analysis rules.
Convert safe index-based loops to enhanced for loops and make intentionally-empty loops explicit to avoid accidental no-ops.
Enforce these PMD rules as CI quality gates so future violations cause the PR quality check to fail.

Description

Replaced empty if/else/while/do..while bodies with explicit behavior such as return, continue, or a minimal harmless expression to make intent clear (examples: ConnectionRequest, JSONSanitizer, Deflate, DeflaterOutputStream, RSSService, GeofenceManager).
Converted many for (int i = 0; ...) index-based loops to enhanced for loops where the index was only used for iteration (examples: FileTreeModel, SimpleDateFormat, PropertyIndex, Dialog, Display, MenuBar, HTMLComponent, GroupLayout, Element, RE, TBigInteger and others).
Preserved loops that must remain indexed by adding explicit comments or // NOPMD ForLoopCanBeForeach where a foreach would be unsafe (example: Form.loopAnimations kept as an indexed loop with a NOPMD annotation).
Made several other small refactorings to avoid empty-statement patterns (e.g. replace // do nothing comments with continue in numeric library code).
Added EmptyControlStatement and ForLoopCanBeForeach to the forbidden PMD rules list in .github/scripts/generate-quality-report.py so future builds will fail the quality-report step on these violations.
The change set touches multiple files (47 files changed) to remediate the reported PMD findings.

Testing

No automated unit tests or Maven builds were executed as part of this change; only source edits and the quality-report script were modified.
The CI quality-report script was updated so the repository's PR checks will now fail if EmptyControlStatement or ForLoopCanBeForeach PMD findings are present (effects will be observed when the PR CI runs).
A commit containing the source edits was created; running the repository's usual mvn CI steps (see AGENTS.md) is recommended to validate compilation and unit tests under Java 8.

Codex Task

shai-almog · 2026-01-21T18:38:16Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.76% (2654/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.41% (12335/50528), branch 15.35% (717/4672), complexity 17.52% (743/4241), method 32.97% (600/1820), class 34.65% (105/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.76% (2654/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.41% (12335/50528), branch 15.35% (717/4672), complexity 17.52% (743/4241), method 32.97% (600/1820), class 34.65% (105/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

github-actions · 2026-01-21T18:53:19Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2282 total, 0 failed, 0 skipped
📊 Line coverage: 52.76% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
  - com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

✅ SpotBugs: 0 findings (no issues) [Report archive]
❌ PMD: 478 findings (P2: 42, P3: 426, P4: 10) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/capture/Capture.java:252 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/compat/java/util/Objects.java:47 – The method name and parameter number are suspiciously close to equals(Object) (rule: SuspiciousEqualsMethodName)
  - P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:43 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:44 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/io/BufferedInputStream.java:38 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - …and 473 more
❌ Checkstyle: 221034 findings (Warning: 221034) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 221029 more

Generated automatically by the PR CI workflow.

shai-almog · 2026-01-21T19:20:47Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 357 seconds
Compilation Time: 179 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	42520 ms
Extract Extensions	27 ms
Google Services Setup	8 ms
Scan Classes	2251 ms
Extract Libs	1303 ms
Inject Build Hints	45 ms
Generate Unit Tests	2 ms
Generate Stubs	1870 ms
Compile Stubs	2932 ms
Generate Icons	1468 ms
Prepare ParparVM	247 ms
ParparVM Execution	197607 ms
Post-VM Setup	157 ms
CocoaPods	4823 ms
Finalize	32 ms
Total Time	255293 msMaven Overhead : 102000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	78000 ms
App Install	23000 ms
App Launch	8000 ms
Test Execution	179000 ms

Fix PMD empty statements and foreach warnings

33fa99b

shai-almog added the codex label Jan 21, 2026 — with ChatGPT Codex Connector

shai-almog added 2 commits January 21, 2026 20:23

Adjust PMD empty statement fixes

85dcbbd

Fix Element toString child casting

9a749d1

Resolve remaining PMD foreach violations

a2b0660

shai-almog added 3 commits January 21, 2026 21:21

Restore intentional empty loops with PMD suppressions

19e614c

Fix PMD suppression placement in AbstractStringBuilder

76d3f6e

Suppress PMD empty loop in AbstractStringBuilder

b32cfed

shai-almog merged commit 610830c into master Jan 22, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PMD EmptyControlStatement and ForLoopCanBeForeach violations and enforce them in quality report#4454

Fix PMD EmptyControlStatement and ForLoopCanBeForeach violations and enforce them in quality report#4454
shai-almog merged 7 commits intomasterfrom
codex/fix-pmd-emptycontrolstatement-and-forloopcanbeforeach

shai-almog commented Jan 21, 2026

Uh oh!

shai-almog commented Jan 21, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

shai-almog commented Jan 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

shai-almog commented Jan 21, 2026

Motivation

Description

Testing

Uh oh!

shai-almog commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shai-almog commented Jan 21, 2026 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading

shai-almog commented Jan 21, 2026 •

edited

Loading