You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Eliminate many PMD warnings by replacing size() comparisons with isEmpty()/!isEmpty() and remove unnecessary fully-qualified names to improve code clarity and static-analysis results.
Make the PMD rules UseCollectionIsEmpty and UnnecessaryFullyQualifiedName cause CI quality-report failures so regressions are caught early.
Description
Replaced collection size comparisons such as size() == 0, size() > 0, size() != 0, and size() < 1 with isEmpty() or !isEmpty() across many source files (examples: XYSeriesRenderer, MathHelper, XYChart, NetworkManager, JSONParser, Result, HTMLComponent, etc.).
Fixed an incorrect expression in Result.java (((List) !selected) -> !((List) selected).isEmpty()).
Removed unnecessary fully-qualified references and relied on existing imports or static imports (examples: MathUtil.atan2 in PieMapper, Container and BorderLayout uses, Date, String, IOException and other common java types).
Normalized imports/typedefs in a number of files (e.g. File.java, URL.java, AsyncResource.java, CSSBorder.java) to avoid redundant qualification and to use the already-imported types or static imports.
Updated the quality-report script .github/scripts/generate-quality-report.py to add UnnecessaryFullyQualifiedName and UseCollectionIsEmpty to the set of forbidden PMD rules so such violations fail the report generation.
Testing
No automated tests (unit or integration) were executed as part of this change.
Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835. Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.
Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835. Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
size()comparisons withisEmpty()/!isEmpty()and remove unnecessary fully-qualified names to improve code clarity and static-analysis results.UseCollectionIsEmptyandUnnecessaryFullyQualifiedNamecause CI quality-report failures so regressions are caught early.Description
size() == 0,size() > 0,size() != 0, andsize() < 1withisEmpty()or!isEmpty()across many source files (examples:XYSeriesRenderer,MathHelper,XYChart,NetworkManager,JSONParser,Result,HTMLComponent, etc.).Result.java(((List) !selected)->!((List) selected).isEmpty()).MathUtil.atan2inPieMapper,ContainerandBorderLayoutuses,Date,String,IOExceptionand other common java types).File.java,URL.java,AsyncResource.java,CSSBorder.java) to avoid redundant qualification and to use the already-imported types or static imports..github/scripts/generate-quality-report.pyto addUnnecessaryFullyQualifiedNameandUseCollectionIsEmptyto the set of forbidden PMD rules so such violations fail the report generation.Testing
Codex Task