You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the existing regression test to cover a different class/interface hierarchy that exercises default methods, inheritance, generics and runtime dispatch to guard against the BytecodeTranslator culling optimization.
Ensure the hierarchy is actually used at runtime so the VM/translator cannot optimize it away by invoking methods and using return values.
Place the replacement test inside the scripts/hellocodenameone sample app so the reproduction runs as part of the example test suite.
Description
Replaced the previous BytecodeTranslatorRegressionTest implementation with a new test that declares interfaces and classes such as Sketchable, SlotProvider, TokenMenuHost, Hue, Marker, TokenMenu, GameCell, and GameViewer and a layered canvas hierarchy (ShellComponent → ProxyCanvas → CommonCanvas → PanelCanvas).
Implemented runtime usage paths that exercise default interface methods, override dispatch, and generics by calling TokenMenu.render, GameViewer.drawToken, GameViewer.drawArrow, GameCell.lastSlot, Marker.score, and GameViewer.buildStatus so values are computed and stored to prevent culling.
Kept the test runnable by launching a short-lived worker thread named cn1-bytecode-regression and calling CN.callSerially(this::done) on success, and updated imports and helper utilities (Dimension, Rectangle, etc.) in scripts/hellocodenameone/common/src/main/java/com/codenameone/examples/hellocodenameone/tests/BytecodeTranslatorRegressionTest.java.
Testing
No automated tests were executed as part of this change.
The new code includes runtime calls that will be exercised when the BytecodeTranslatorRegressionTest is run by the hellocodenameone example test harness or CI.
CI/core unit tests were not invoked locally for this edit.
Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835. Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.
Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835. Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scripts/hellocodenameonesample app so the reproduction runs as part of the example test suite.Description
BytecodeTranslatorRegressionTestimplementation with a new test that declares interfaces and classes such asSketchable,SlotProvider,TokenMenuHost,Hue,Marker,TokenMenu,GameCell, andGameViewerand a layered canvas hierarchy (ShellComponent→ProxyCanvas→CommonCanvas→PanelCanvas).TokenMenu.render,GameViewer.drawToken,GameViewer.drawArrow,GameCell.lastSlot,Marker.score, andGameViewer.buildStatusso values are computed and stored to prevent culling.cn1-bytecode-regressionand callingCN.callSerially(this::done)on success, and updated imports and helper utilities (Dimension,Rectangle, etc.) inscripts/hellocodenameone/common/src/main/java/com/codenameone/examples/hellocodenameone/tests/BytecodeTranslatorRegressionTest.java.Testing
BytecodeTranslatorRegressionTestis run by the hellocodenameone example test harness or CI.Codex Task