Skip to content

Fix PMD OneDeclarationPerLine violations#4447

Merged
shai-almog merged 2 commits intomasterfrom
codex/fix-onedeclarationperline-violations
Jan 20, 2026
Merged

Fix PMD OneDeclarationPerLine violations#4447
shai-almog merged 2 commits intomasterfrom
codex/fix-onedeclarationperline-violations

Conversation

@shai-almog
Copy link
Collaborator

Motivation

  • Reduce PMD noise and improve readability by ensuring each variable declaration is on its own line to satisfy the OneDeclarationPerLine rule.
  • Prevent regressions by making OneDeclarationPerLine a forbidden PMD rule so future builds fail if new violations are introduced.

Description

  • Split multi-variable declarations into single-line declarations across many source files (examples include ChartComponent.java, ImageViewer.java, Grid.java, CC.java, Properties.java, Deflate.java, Tree.java, GeneralPath.java, and dozens more), converting statements like int a, b; into int a; / int b; and similar for double, float, boolean, String, object references, arrays, etc.
  • Normalized a number of grouped declarations to individual lines for clarity in core UI, layout, IO, util, and gzip-related classes.
  • Updated the quality report enforcement by adding "OneDeclarationPerLine" to the PMD forbidden rules in .github/scripts/generate-quality-report.py so PMD findings for this rule will cause CI quality-report generation to fail, matching the existing SpotBugs enforcement behavior.

Testing

  • No automated tests were run as part of this change (no mvn/unit test invocation was executed).

Codex Task

@shai-almog
Copy link
Collaborator Author

shai-almog commented Jan 19, 2026

Compared 30 screenshots: 30 matched.

Native Android coverage

  • 📊 Line coverage: 24.88% (2666/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.47% (12366/50528), branch 15.33% (716/4672), complexity 17.59% (746/4241), method 33.13% (603/1820), class 34.98% (106/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 24.88% (2666/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.47% (12366/50528), branch 15.33% (716/4672), complexity 17.59% (746/4241), method 33.13% (603/1820), class 34.98% (106/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

@shai-almog
Copy link
Collaborator Author

shai-almog commented Jan 19, 2026

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-arc
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 373 seconds
  • Compilation Time: 172 seconds

Detailed Performance Metrics

Metric Duration
Build Time Statistics
Setup & Unzip 35794 ms
Extract Extensions 20 ms
Google Services Setup 2 ms
Scan Classes 1281 ms
Extract Libs 918 ms
Inject Build Hints 35 ms
Generate Unit Tests 5 ms
Generate Stubs 1184 ms
Compile Stubs 2296 ms
Generate Icons 985 ms
Prepare ParparVM 226 ms
ParparVM Execution 213674 ms
Post-VM Setup 202 ms
CocoaPods 5092 ms
Finalize 49 ms
Total Time 261764 msMaven Overhead : 112000 ms
CocoaPods Install (Script) 2000 ms
Simulator Boot (Run) 174000 ms
App Install 25000 ms
App Launch 18000 ms
Test Execution 218000 ms

@github-actions
Copy link

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog shai-almog merged commit e52a5dc into master Jan 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant