Reformatted the project to create a more uniform codebase by shai-almog · Pull Request #4441 · codenameone/CodenameOne

shai-almog · 2026-01-19T02:57:15Z

No description provided.

shai-almog · 2026-01-19T03:40:03Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.76% (2654/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.40% (12330/50528), branch 15.30% (715/4672), complexity 17.52% (743/4241), method 32.97% (600/1820), class 34.65% (105/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.76% (2654/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.40% (12330/50528), branch 15.30% (715/4672), complexity 17.52% (743/4241), method 32.97% (600/1820), class 34.65% (105/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

github-actions · 2026-01-19T03:49:04Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2282 total, 0 failed, 0 skipped
📊 Line coverage: 52.74% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
  - com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

✅ SpotBugs: 0 findings (no issues) [Report archive]
❌ PMD: 2249 findings (P2: 42, P3: 1929, P4: 278) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/capture/Capture.java:250 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/compat/java/util/Objects.java:47 – The method name and parameter number are suspiciously close to equals(Object) (rule: SuspiciousEqualsMethodName)
  - P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:43 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:44 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/io/BufferedInputStream.java:38 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - …and 2244 more
❌ Checkstyle: 220874 findings (Warning: 220874) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 220869 more

Generated automatically by the PR CI workflow.

shai-almog · 2026-01-19T04:03:55Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 268 seconds
Compilation Time: 95 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	23638 ms
Extract Extensions	14 ms
Google Services Setup	2 ms
Scan Classes	436 ms
Extract Libs	848 ms
Inject Build Hints	27 ms
Generate Unit Tests	2 ms
Generate Stubs	773 ms
Compile Stubs	1911 ms
Generate Icons	727 ms
Prepare ParparVM	148 ms
ParparVM Execution	160797 ms
Post-VM Setup	133 ms
CocoaPods	4280 ms
Finalize	16 ms
Total Time	193752 msMaven Overhead : 75000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	52000 ms
App Install	12000 ms
App Launch	8000 ms
Test Execution	127000 ms

shai-almog force-pushed the code-reformatting-missing-brackets branch 2 times, most recently from ce7de35 to 7cebaf5 Compare January 19, 2026 03:26

shai-almog force-pushed the code-reformatting-missing-brackets branch from 7cebaf5 to 5773739 Compare January 19, 2026 03:42

Reformatted the project to create a more uniform codebase

1bbd8d9

shai-almog force-pushed the code-reformatting-missing-brackets branch from 5773739 to 1bbd8d9 Compare January 19, 2026 05:02

shai-almog merged commit 644ab2f into master Jan 19, 2026
12 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reformatted the project to create a more uniform codebase#4441

Reformatted the project to create a more uniform codebase#4441
shai-almog merged 1 commit intomasterfrom
code-reformatting-missing-brackets

shai-almog commented Jan 19, 2026

Uh oh!

shai-almog commented Jan 19, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 19, 2026 •

edited

Loading

Uh oh!

shai-almog commented Jan 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

shai-almog commented Jan 19, 2026

Uh oh!

shai-almog commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

github-actions bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shai-almog commented Jan 19, 2026 •

edited

Loading

github-actions bot commented Jan 19, 2026 •

edited

Loading

shai-almog commented Jan 19, 2026 •

edited

Loading