Skip to content

Implement durationMode in TimeSpinner3D #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shai-almog merged 2 commits into from
Jan 2, 2026
Merged

Implement durationMode in TimeSpinner3D #4379

shai-almog merged 2 commits into from
Jan 2, 2026

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Jan 2, 2026

Implemented durationMode functionality in TimeSpinner3D component to allow users to select a duration in hours and minutes. This includes:

  • Added setDurationMode(boolean) method.
  • Updated addComponents() to display "hours" and "minutes" labels in duration mode.
  • Updated rebuildHours() to support 0-24 hour range for duration mode.
  • Ensured showMeridiem is disabled when duration mode is active.
  • Added localized "hours" and "minutes" labels.
  • Verified functionality with a unit test (deleted before submission).

PR created automatically by Jules for task 5365746536366648880 started by @shai-almog

@google-labs-jules
Implemented durationMode in TimeSpinner3D
6c9df2e 
Added setDurationMode(boolean) logic to toggle duration mode (0-24h range, no meridiem).
Updated addComponents to include "hours" and "minutes" labels when in duration mode.
Updated rebuildHours to adjust startHour/endHour for duration mode.
Verified with TimeSpinner3DTest.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Jan 2, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026 •
edited
Loading

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Collaborator

shai-almog commented Jan 2, 2026 •
edited
Loading

Compared 30 screenshots: 30 matched.

Native Android coverage

  • 📊 Line coverage: 24.60% (2635/10711 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.12% (12180/50505), branch 15.17% (708/4668), complexity 17.37% (736/4237), method 32.56% (592/1818), class 33.99% (103/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 24.60% (2635/10711 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.12% (12180/50505), branch 15.17% (708/4668), complexity 17.37% (736/4237), method 32.56% (592/1818), class 33.99% (103/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

@shai-almog
Copy link
Collaborator

shai-almog commented Jan 2, 2026 •
edited
Loading

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-arc
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 287 seconds
  • Compilation Time: 54 seconds

Detailed Performance Metrics

Metric Duration
Build Time Statistics
Setup & Unzip 25791 ms
Extract Extensions 13 ms
Google Services Setup 2 ms
Scan Classes 921 ms
Extract Libs 509 ms
Inject Build Hints 29 ms
Generate Unit Tests 2 ms
Generate Stubs 861 ms
Compile Stubs 2002 ms
Generate Icons 905 ms
Prepare ParparVM 156 ms
ParparVM Execution 168089 ms
Post-VM Setup 98 ms
CocoaPods 4540 ms
Finalize 13 ms
Total Time 203931 msMaven Overhead : 84000 ms
CocoaPods Install (Script) 1000 ms
Simulator Boot (Run) 45000 ms
App Install 15000 ms
App Launch 4000 ms
Test Execution 139000 ms

@google-labs-jules
Implemented durationMode in TimeSpinner3D and added unit test.
cad42bb 
- In `TimeSpinner3D.java`:
    - Implemented `setDurationMode(boolean)` to update state and rebuild UI.
    - Updated `addComponents` to add "hours" and "minutes" labels in duration mode.
    - Updated `rebuildHours` to set correct hour range (0-24) for duration mode.
- Added `TimeSpinner3DTest.java` in `maven/core-unittests` to verify duration mode behavior.
@shai-almog shai-almog marked this pull request as ready for review January 2, 2026 18:09
@shai-almog shai-almog merged commit 7198cdd into master Jan 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shai-almog