FIX: Fix detection of a parent transformed element on Firefox #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Firefox 144, offsetParent is now `null` when an element has position fixed (while previously, it would return `<body>`). The hack previously used for Firefox is not working anymore and we have to use the same method as for Chromium.
Member
|
I'm still seeing the old behavior in Firefox 144. This is the test I used. <div style="transform: translate(50px, 50px)"><div id=fix style="position: fixed; left: 0; right: 0">--</div></div>
<script>console.log(document.querySelector("#fix").offsetParent)</script> |
Author
|
I just took a random element on this page: |
marijnh
added a commit
that referenced
this pull request
Oct 21, 2025
Now that browsers seem to properly set offsetParent to null for fixed elements. FIX: Make detection of transformed tooltip parent elements (forcing absolute positioning) more robust on current browsers. Issue #74
Member
|
That looks like an improvement— |
Author
|
Yes, it works fine as well. |
vincentbernat
added a commit
to akvorado/akvorado
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Firefox 144, offsetParent is now
nullwhen an element has position fixed (while previously, it would return<body>). The hack previously used for Firefox is not working anymore and we have to use the same method as for Chromium.I don't have a reference for the change. The bug on Firefox side is still open but with an activity a few months ago. There are also traces it has been fixed in some subsequent commits.