Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying selection with blank line loses it on paste #2452

Closed
njx opened this issue Apr 9, 2014 · 5 comments
Closed

Copying selection with blank line loses it on paste #2452

njx opened this issue Apr 9, 2014 · 5 comments

Comments

@njx
Copy link
Contributor

njx commented Apr 9, 2014

Reproduced on Mac Chrome 34

  1. Open demo/theme.html
  2. Click at the beginning of the second line
  3. Hit enter to insert a blank line (second line should now be totally blank, no spaces)
  4. Select the first two lines
  5. Click elsewhere and paste

Result: Only the first line is pasted. The blank line is lost.

@njx
Copy link
Contributor Author

njx commented Apr 9, 2014

This appears to be because of 475b2be - the comment for that commit suggests that it removed a hack that was no longer necessary for #1474 (in order to fix #2384), but it seems like #1474 still reproduces, at least in Mac Chrome.

@njx
Copy link
Contributor Author

njx commented Apr 9, 2014

@marijnh - we're right in the middle of finishing up our release, and I'm tempted to just reintroduce the original fakedLastChar hack for now in order to get it out the door (I think we'd be willing to live with #2384 for now). Do you think there's any risk to doing so? Since that hack had been in CM for 9 months and doesn't look like it should affect/be affected by any other parts of CM, it seems safe enough to me, but I wanted to double check with you. Thanks!

@marijnh
Copy link
Member

marijnh commented Apr 9, 2014

Argh, my test (which made me conclude this was fixed) was off. This is indeed still happening. I'll revert the patch that kill the hack. That should indeed not cause any trouble, apart from #2384 (which I haven't been able to reproduce).

marijnh added a commit that referenced this issue Apr 9, 2014
This reverts commit 475b2be.

Issue #2452
Issue #2384
@marijnh
Copy link
Member

marijnh commented Apr 9, 2014

Reverted in attached patch. Closing this, reopening #2384

@marijnh marijnh closed this as completed Apr 9, 2014
@njx
Copy link
Contributor Author

njx commented Apr 9, 2014

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants