Fix Issue 113: Call graph is missing edges to implementations of interface classes. Merge to main. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
5 tasks
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
…ion to use try-with-resources Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
rahlk
changed the title
rangeetpan
approved these changes
Feb 17, 2025
rahlk
deleted the
113-call-graph-is-missing-edges-to-implementations-of-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove entrypoint methods filter so WALA can use every method to build it's call graph thereby enabling package private methods/classes.
Motivation and Context
Call graph edges do not resolve to interface class subtypes or to/from package private methods
How Has This Been Tested?
We added a new test application with a package private method(s) and an integration test to ensure that these methods were indeed present in the call graph.
Breaking Changes
No.
Types of changes
Checklist
Additional context
For now, we keep
RTACallGraphBuilder(...)for speed and scalability.