Skip to content

Bump elasticsearch from 7.9.3 to 7.16.3 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2022
Merged

Bump elasticsearch from 7.9.3 to 7.16.3 #31

merged 2 commits into from
Mar 12, 2022

Conversation

matsui-stb
Copy link
Contributor

@matsui-stb matsui-stb commented Mar 1, 2022 •
edited
Loading

Reference

Problem

Unit tests fail

[ERROR] Failures: 
[ERROR]   DynamicRankingPluginTest.diversitySort:535 expected:<[7]> but was:<[2]>
[ERROR]   DynamicRankingPluginTest.keepTop5:1043 expected:<[9]> but was:<[7]>
[ERROR]   DynamicRankingPluginTest.reorder_with_ignored:939 expected:<[7]> but was:<[2]>

@matsui-stb matsui-stb force-pushed the 7.16.x branch 2 times, most recently from 261a506 to b036621 Compare March 6, 2022 15:11
@matsui-stb matsui-stb changed the title [wip]Bump elasticsearch from 7.9.3 to 7.16.3 Bump elasticsearch from 7.9.3 to 7.16.3 Mar 6, 2022
@matsui-stb
Copy link
Contributor Author

@marevol 確認お願いします

type:minhashの値のByteArrayからStringへの変更に対応しました。
マッピング情報(MappingMetadata.sourceAsMap)をScriptInfo.settings->StandardBuckets.paramsと渡すようにして、値の比較の時minhashの値ならMinHash.compareで比較するようにしました。

@marevol
Copy link
Contributor

marevol commented Mar 8, 2022

Thank you for the PR.
I think StandardBucket should not depend on a minhash.
If you want to use a minhash, creating a new bucket and factory is better.

@matsui-stb
add minhash to bucketFactory
bd4ca5d 
revert StandardBucket
add MinhashBucket
switch between 'standard' and 'minhash' in 'dynarank.script_sort.params.bucket_factory'
@matsui-stb
Copy link
Contributor Author

@marevol Fixed. Please check.

  • add Minhash Bucket, Bukets, BuketFactory
  • switch between 'standard' and 'minhash' in 'dynarank.script_sort.params.bucket_factory'

@marevol marevol merged commit c32c4e5 into codelibs:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matsui-stb @marevol