fix: component instance children rendering #3824
Open
+64
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladyslav-polishchuk
changed the title
vladyslav-polishchuk
force-pushed
the
fix/3820-component-instance-children
branch
2 times, most recently
from
6581696 to
23c2e3a
Compare
vladyslav-polishchuk
force-pushed
the
fix/3820-component-instance-children
branch
2 times, most recently
from
bbc3bab to
1f61396
Compare
vladyslav-polishchuk
force-pushed
the
fix/3820-component-instance-children
branch
from
1f61396 to
c314845
Compare
| await this.clickModalConfirmButton() | ||
|
|
||
| await expect(this.getGlobalProgressBar()).toBeHidden() | ||
| await this.waitForProgressBar() |
There was a problem hiding this comment.
This first waits for progressbar to appear and then dissappear. This is more reliable then just checking it does not exist. Since this check may pass even before the form autosubmits
vladyslav-polishchuk
force-pushed
the
fix/3820-component-instance-children
branch
from
cb18ea1 to
8da644c
Compare
vladyslav-polishchuk
force-pushed
the
fix/3820-component-instance-children
branch
from
8da644c to
75e427c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #3820