fix: impossible to submit update action form #3822
Open
+7
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| method: { | ||
| allowedValues: keys(HttpMethod) as Array<HttpMethod>, | ||
| enum: keys(HttpMethod) as Array<HttpMethod>, |
There was a problem hiding this comment.
Not directly related to the issue, just noticed that enum fields were generated as plain text field, instead of select component with options. This will fix that
| }, | ||
| ...refSchema('resource'), | ||
| ...refSchema('store', { disabled: true }), | ||
| ...refMaybeSchema('resource', { label: 'Resource' }), |
There was a problem hiding this comment.
This is the fix: resource field was a required field, even though it does not exist on code actions
| const actionService = useActionService() | ||
| const { actionDomainService, resourceDomainService } = useDomainStore() | ||
| const actionSchema = useActionSchema(updateActionSchema) | ||
| const { builderService } = useApplicationStore() |
There was a problem hiding this comment.
Just unused dependency
vladyslav-polishchuk
force-pushed
the
fix/3821-cant-submit-action-form
branch
from
a271ab2 to
b2a1ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #3821