[김소영] sprint 6 #321
Merged
[김소영] sprint 6 #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
approved these changes
Feb 4, 2025
src/components/ItemCard.jsx
Outdated
| import styles from "./ItemCard.module.css"; | ||
|
|
||
| function ItemCard({ className, item }) { | ||
| const thumbnailUrl = "https://example.com/..."; |
There was a problem hiding this comment.
상수라서 컴포넌트 밖에 선언해주시는 걸 추천드려요!
Suggested change
| const thumbnailUrl = "https://example.com/..."; | |
| const THUMBNAIL_URL = "https://example.com/..." as const; |
src/components/ItemCard.jsx
Outdated
Comment on lines
13
to
15
| item.images.some((image) => image === thumbnailUrl) | ||
| ? noImage | ||
| : item.images[0] |
There was a problem hiding this comment.
요 부분은 위쪽에서 계산해주고 return 에는 결과만 내려줘도 될 거 같아요! item.images 가 변할 때에만 src 가 바뀌도록 useMemo 를 선언해주면 최적화도 될 거 같네요!
const imageSource = useMemo(() =>
item.images.some((image) => image === thumbnailUrl) ? noImage : item.images[0],
[item.images])
...
return (
...
<img src={imageSource}>
)
src/components/ItemCard.jsx
Outdated
| import styles from "./ItemCard.module.css"; | ||
|
|
||
| function ItemCard({ className, item }) { | ||
| const thumbnailUrl = "https://example.com/..."; |
There was a problem hiding this comment.
item 자체를 쓰는 경우는 없고 다 item 내의 프로퍼티들을 쓰니까 앞에서 구조 분해해서 가면 아래 코드도 간결해질 거 같아요
const {images, name, price, favoriteCount} = item
src/components/Nav.jsx
Outdated
| <div className="nav_center">{center}</div> | ||
| <div className="nav_user">{rightChild}</div> | ||
| </nav> | ||
| <div className={styles.Nav}> |
There was a problem hiding this comment.
클래스네임에는 절대 대문자는 지양해주세요!
Suggested change
| <div className={styles.Nav}> | |
| <div className={styles.�nav}> |
src/components/Nav.jsx
Outdated
| @@ -1,12 +1,28 @@ | |||
| import './Nav.css'; | |||
| import styles from "./Nav.module.css"; | |||
| import Nav_logo from "../assets/nav_panda_logo_img.png"; | |||
There was a problem hiding this comment.
요소 이름은 파스칼 케이스가 일반적인 거 같아용
Suggested change
| import Nav_logo from "../assets/nav_panda_logo_img.png"; | |
| import NavLogo from "../assets/nav_panda_logo_img.png"; |
src/pages/Login.jsx
Outdated
Comment on lines
21
to
23
| if (!emailRegex.test(email)) { | ||
| return "잘못된 이메일 형식입니다"; | ||
| } |
src/pages/Login.jsx
Outdated
| const Navigate = useNavigate(); | ||
|
|
||
| // 이메일 값 체크 | ||
| const EmailCheck = (email) => { |
There was a problem hiding this comment.
컴포넌트 내부 함수는 소문자로 시작해야해요! (대문자 시작은 컴포넌트 이름만!)
Suggested change
| const EmailCheck = (email) => { | |
| const emailCheck = (email) => { |
src/pages/Login.jsx
Outdated
|
|
||
| // 비밀번호 값 체크 | ||
| const PasswordCheck = (password) => { | ||
| const PASSWORD_MIN_LEN = 8; |
src/pages/Login.jsx
Outdated
|
|
||
| if (!password.trim()) { | ||
| return `패스워드를 입력해주세요`; | ||
| } else { |
There was a problem hiding this comment.
여기도 early return 쓰면 좋을 거 같아용
src/pages/Signup.jsx
Outdated
Comment on lines
97
to
109
| if ( | ||
| !emailError && | ||
| !nickNameError && | ||
| !passwordError && | ||
| !passwordMatchError && | ||
| email && | ||
| nickName && | ||
| password && | ||
| passwordMatch | ||
| ) { | ||
| return setIsButtonDisabled(false); | ||
| } | ||
| return setIsButtonDisabled(true); |
There was a problem hiding this comment.
요렇게 조건이 많을 때에는 읽기 좋게 어떤 조건인지 나눠줘도 좋을 거 같아요
Suggested change
| if ( | |
| !emailError && | |
| !nickNameError && | |
| !passwordError && | |
| !passwordMatchError && | |
| email && | |
| nickName && | |
| password && | |
| passwordMatch | |
| ) { | |
| return setIsButtonDisabled(false); | |
| } | |
| return setIsButtonDisabled(true); | |
| const isNoError = !emailError && !nickNameError && !passwordError && !passwordMatchError | |
| const hasAllInput = email && nickName && password && passwordMatch | |
| setIsButtonDisabled(!(isNoError && hasAllInput)) |
|
충돌사항들이 좀 있는데 해소하고 꼭 머지해주셔요 😃 |
kimsoyoung96
force-pushed
the
React-김소영-sprint7
branch
from
36841dd to
4cf1edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
상품 등록
심화
주요 변경사항
스크린샷
멘토에게