[송형진] sprint8 #318
Merged
[송형진] sprint8 #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
approved these changes
Jan 27, 2025
| interface PostCommentDataParams { | ||
| productId?: string; | ||
| editContent: string; | ||
| } |
There was a problem hiding this comment.
타입이 꽤 많아서 따로 type.ts 에 정의해도 괜찮을 거 같아요!
| </li> | ||
| ))} | ||
| {allItemList.map( | ||
| ({ id, images, name, price, favoriteCount }: Product) => ( |
There was a problem hiding this comment.
allItemList가 Product[] 타입인 것을 위에 정의할 때에 vsCode 에게 알려줬기 때문에 여기는 따로 적을 필요 없을 거 같아요!
Suggested change
| ({ id, images, name, price, favoriteCount }: Product) => ( | |
| ({ id, images, name, price, favoriteCount }) => ( |
Comment on lines
+84
to
+85
| const created: number = new Date(createdAt).getTime(); | ||
| const updated: number = new Date(updatedAt).getTime(); |
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getTime
Date 객체의 .getTime() 메서드는 기본적으로 number 를 리턴하기에 명시해주지 않아도 될 거 같아요!
다만 잘못된 값의 경우 NaN 를 리턴하기에 이에 대한 예외처리도 있으면 좋을 거 같아요~
|
|
||
| //omit으로 size 속성 제외 | ||
| interface ItemData | ||
| extends Omit<SpecificProductProps, "size" | "imageUrl" | "likeCount"> { |
Comment on lines
+6
to
+13
| interface ProductItemData { | ||
| id: number; | ||
| imageUrl: string; | ||
| name: string; | ||
| price: number; | ||
| likeCount: number; | ||
| size: number; | ||
| } |
There was a problem hiding this comment.
SpecificProductProps 에 모두 있는 요소인 거 같은데, 물론 요소만 비슷하고, 전혀 관계없는 타입인 경우엔 상관없지만, ProductItemData 중에 특정 상품의 경우 더 많은 정보가 주어지는 경우 type SpecificProductProps = ProductItemData extends {..} 요런식으로 짜줘도 좋을 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게